Changes of Revision 28 - OVPN

ovpn.spec Changed

ovpn_2.4.0.orig.tar.gz/VER_IID Changed

ovpn_2.4.0.orig.tar.gz/pvs-logs/pvs-tasks-client-2022_12_09__11_11_15.log Deleted

@@ -1,8 +0,0 @@
-pvs-studio.com/en/docs/warnings/	1	err	Help: The documentation for all analyzer warnings is available here: https://pvs-studio.com/en/docs/warnings/.
-client/utils/ipc/linux/IPCAppLinux.cpp	124	warn	V560 A part of conditional expression is always false: !replyString.
-client/utils/sentrysdk.cpp	1	err	V008 Unable to start the analysis on this file.
-client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the third actual argument of the 'sscanf' function. It's dangerous to use string specifier without width specification. Buffer overflow is possible.
-client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the fourth actual argument of the 'sscanf' function. A pointer to the unsigned long type is expected.
-client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the fifth actual argument of the 'sscanf' function. A pointer to the unsigned long type is expected.
-client/utils/network/linux/NetworkControllerLinux.cpp	66	warn	V547 Expression 'file' is always true.
-client/utils/network/linux/NetworkControllerLinux.cpp	99	err	V547 Expression 'family == 2' is always true.

ovpn_2.4.0.orig.tar.gz/pvs-logs/pvs-tasks-client-2022_12_09__12_38_46.log Added

@@ -0,0 +1,8 @@
+pvs-studio.com/en/docs/warnings/	1	err	Help: The documentation for all analyzer warnings is available here: https://pvs-studio.com/en/docs/warnings/.
+client/utils/sentrysdk.cpp	1	err	V008 Unable to start the analysis on this file.
+client/utils/ipc/linux/IPCAppLinux.cpp	124	warn	V560 A part of conditional expression is always false: !replyString.
+client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the third actual argument of the 'sscanf' function. It's dangerous to use string specifier without width specification. Buffer overflow is possible.
+client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the fourth actual argument of the 'sscanf' function. A pointer to the unsigned long type is expected.
+client/utils/network/linux/NetworkControllerLinux.cpp	56	warn	V576 Incorrect format. Consider checking the fifth actual argument of the 'sscanf' function. A pointer to the unsigned long type is expected.
+client/utils/network/linux/NetworkControllerLinux.cpp	66	warn	V547 Expression 'file' is always true.
+client/utils/network/linux/NetworkControllerLinux.cpp	99	err	V547 Expression 'family == 2' is always true.

ovpn_2.4.0.orig.tar.gz/pvs-logs/pvs-tasks-ovpn-daemon-2022_12_09__11_11_33.log Deleted

ovpn_2.4.0.orig.tar.gz/pvs-logs/pvs-tasks-ovpn-daemon-2022_12_09__12_39_04.log Added

ovpn_2.4.0.orig.tar.gz/pvs-logs/pvs.log Changed

@@ -14,11 +14,11 @@
 #
 #
 d99cf3ba-6fcd-43f9-9260-1179fa3a9bed
-r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(=oUao8vk>}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
 r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(=uo_>=}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
-r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=('8PPU>_}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
+r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(=oUao8vk>}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
 r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=('8PPU>_=}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
 r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=( -auU22}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
+r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(28j8  }'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
 r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(s-228vk>}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
+r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=('8PPU>_}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
 r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(=o8k8vk>}'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3
-r-vUVbw<6y|D3 h22y|D3xy|D3(L8Pu(j-o2U9wah>>ua(9h-2_=(Mokv~{U-(S(ouUP(_u=so8kw'2-u>o(=a'(8vk>w_UuP8>('8PPU>_=(28j8  }'kky|D3uaa8ay|D3rSSXy|D3g>U92uco8c=oUaocoLucU>U2f=-=c8>coL-=c -2u}y|D3 U2=uy|D3Sy|D3y|D3y|D3y|D3xy|D3

ovpn_2.4.0.orig.tar.gz/src/client/ovpn/dnssettings.cpp Deleted

@@ -1,150 +0,0 @@
-#include <QDebug>
-
-#include "dnssettings.h"
-
-namespace OvpnSe { namespace Ovpn {
-
-QString DnsSettings::itemSeparator = ";";
-QString DnsSettings::subItemSeparator = ",";
-QString DnsSettings::settingsSeparator = "#";
-
-DnsSettings::DnsSettings()
-{
-    m_dnsIpv4ObtainIPAddressAutomatically = true;
-    m_dnsIpv6ObtainIPAddressAutomatically = true;
-}
-
-DnsSettings::DnsSettings(const QString& id, const QString& networkAdapterName,
-                         bool dnsIpv4ObtainIPAddressAutomatically, bool dnsIpv6ObtainIPAddressAutomatically)
-{
-    m_id = id;
-    m_networkAdapterName = networkAdapterName;
-
-    m_dnsIpv4ObtainIPAddressAutomatically = dnsIpv4ObtainIPAddressAutomatically;
-    m_dnsIpv6ObtainIPAddressAutomatically = dnsIpv6ObtainIPAddressAutomatically;
-}
-
-void DnsSettings::setDnsServerListIpv4(const QStringList& list)
-{
-    m_dnsServerListIPv4 = list;
-}
-
-void DnsSettings::appendToDnsServerListIpv4(const QString& dnsServerIPv4)
-{
-    m_dnsServerListIPv4.push_back(dnsServerIPv4);
-}
-
-void DnsSettings::setDnsServerListIpv6(const QStringList& list)
-{
-    m_dnsServerListIPv6 = list;
-}
-
-void DnsSettings::appendToDnsServerListIpv6(const QString& dnsServerIPv6)
-{
-    m_dnsServerListIPv6.push_back(dnsServerIPv6);
-}
-
-QString DnsSettings::id() const
-{
-    return m_id;
-}
-
-bool DnsSettings::dnsIpv4ObtainIPAddressAutomatically() const
-{
-    return m_dnsIpv4ObtainIPAddressAutomatically;
-}
-
-bool DnsSettings::dnsIpv6ObtainIPAddressAutomatically() const
-{
-    return m_dnsIpv6ObtainIPAddressAutomatically;
-}
-
-QString DnsSettings::toStringIPv4() const
-{
-    return m_dnsServerListIPv4.join(",");
-}
-
-QString DnsSettings::toStringIPv6() const
-{
-    return m_dnsServerListIPv6.join(",");
-}
-
-int DnsSettings::indexInDnsSettingsList(const DnsSettingsList& list, const QString& id)
-{
-    for (int i = 0 ; i < list.size(); i++) {
-        if (list.at(i).id() == id) {
-            return i;
-        }
-    }
-    return -1;
-}
-
-void DnsSettings::debugInfo() const
-{
-    qDebug().nospace() << "DnsSettings: Adapter (debug info): " << m_networkAdapterName
-                       << ", DNS IPv4: " << m_dnsServerListIPv4
-                       << ", DNS IPv6: " << m_dnsServerListIPv6;
-}
-
-QStringList DnsSettings::mergeLists() const
-{
-    return m_dnsServerListIPv4 + m_dnsServerListIPv6;
-}
-
-QString DnsSettings::toString() const
-{
-    QString result;
-
-    result += "ID=" + m_id;
-    result += itemSeparator + "NAME=" + m_networkAdapterName;
-    result += itemSeparator + "IPV4=" + ((m_dnsIpv4ObtainIPAddressAutomatically && m_dnsServerListIPv4.isEmpty())
-                                         ? "" : m_dnsServerListIPv4.join(subItemSeparator));
-    result += itemSeparator + "IPV6=" + ((m_dnsIpv6ObtainIPAddressAutomatically && m_dnsServerListIPv6.isEmpty())
-                                         ? "" : m_dnsServerListIPv6.join(subItemSeparator));
-
-    return result;
-}
-
-QString DnsSettings::toString(const DnsSettingsList& dnsSettingsList)
-{
-    QString resultString;
-    for (int i =0; i < dnsSettingsList.size(); i++) {
-        resultString += (resultString.isEmpty() ? dnsSettingsListi.toString()
-                                                : (settingsSeparator + dnsSettingsList.at(i).toString()));
-    }
-    return resultString;
-}
-
-QString DnsSettings::extractItem(const QString& data, const QString& name)
-{
-    QString s = data;
-    return s.replace(name + "=", QString());
-}
-
-bool DnsSettings::fromString(const QString& text, DnsSettingsList& dnsSettingsList)
-{
-    dnsSettingsList.clear();
-
-    if (text.isEmpty()) {
-        return true;
-    }
-
-    QStringList settings = text.split(settingsSeparator);
-    for (int i = 0; i < settings.size(); i++) {
-        QStringList items = settings.at(i).split(itemSeparator);
-        if (items.size() != 4) {
-            continue;
-        }
-
-        DnsSettings d;
-        d.m_id = extractItem(items.at(0), "ID");
-        d.m_networkAdapterName = extractItem(items.at(1), "NAME");
-        d.m_dnsServerListIPv4 = extractItem(items.at(2), "IPV4").split(",");
-        d.m_dnsServerListIPv6 = extractItem(items.at(3), "IPV6").split(",");
-        dnsSettingsList.append(d);
-    }
-
-    return dnsSettingsList.size();
-}
-
-}}

ovpn_2.4.0.orig.tar.gz/src/client/ovpn/dnssettings.h Deleted

@@ -1,87 +0,0 @@
-#ifndef DNSSETTINGS_H
-#define DNSSETTINGS_H
-
-#include <QStringList>
-
-namespace OvpnSe {
-namespace Ovpn {
-
-class DnsSettings;
-typedef QList<DnsSettings> DnsSettingsList;
-
-//! The DnsSettings is the class used to store DNS settings
-class DnsSettings
-{
-
-public:
-    DnsSettings();
-
-    //! Create DnsSettings with adapter ID, on Windows is network adapter id, on macOS - adapter name
-    DnsSettings(const QString& id, const QString& networkAdapterName,
-                bool dnsIpv4ObtainIPAddressAutomatically, bool dnsIpv6ObtainIPAddressAutomatically);
-
-    //! Search in list and return index in list
-    static int indexInDnsSettingsList(const DnsSettingsList& list, const QString& id);
-
-    //! Save DNS list as text string
-    static QString toString(const DnsSettingsList& dnsSettingsList);
-
-    //! Save DNS data as text string
-    static bool fromString(const QString& text, DnsSettingsList& dnsSettingsList);
-
-    //! Check if DNS in "auto" mode for Ipv4
-    bool dnsIpv4ObtainIPAddressAutomatically() const;
-
-    //! Check if DNS in "auto" mode for Ipv6
-    bool dnsIpv6ObtainIPAddressAutomatically() const;
-
-    //! Set DNS servers for IPv4
-    void setDnsServerListIpv4(const QStringList& dnsServerListIPv4);
-
-    //! Append to DNS servers for IPv4
-    void appendToDnsServerListIpv4(const QString& dnsServerIPv4);
-
-    //! Set DNS servers for IPv6
-    void setDnsServerListIpv6(const QStringList& dnsServerListIPv6);
-
-    //! Append to DNS servers for IPv6
-    void appendToDnsServerListIpv6(const QString& dnsServerIPv6);
-
-    //! This function return list of DNS servers for IPv4
-    QString toStringIPv4() const;
-
-    //! This function return list of DNS servers for IPv6
-    QString toStringIPv6() const;
-
-    //! Mereg IPv4 and IPv6 into one string
-    QStringList mergeLists() const;
-
-    //! Save DNS as text string
-    QString toString() const;
-
-    //! Get adapter ID
-    QString id() const;
-
-    //! Print debug info with name and DNS server list
-    void debugInfo() const;
-
-protected:
-    static QString extractItem(const QString& data, const QString& name);
-
-    static QString itemSeparator;
-    static QString subItemSeparator;
-    static QString settingsSeparator;
-
-    bool m_dnsIpv4ObtainIPAddressAutomatically;
-    bool m_dnsIpv6ObtainIPAddressAutomatically;
-
-    QStringList m_dnsServerListIPv4;
-    QStringList m_dnsServerListIPv6;
-
-    QString m_id;
-    QString m_networkAdapterName;
-};
-
-}}
-
-#endif // DNSSETTINGS_H

ovpn_2.4.0.orig.tar.gz/src/client/ovpn/ovpn.pri Changed